Fix encoding of Brazilian Portuguese localization #8549

basil · 2023-10-02T19:01:48Z

#8543 (accidentally?) changed the encoding of a Brazilian Portuguese localization from UTF-8 to ISO-8859-1. As of a few months back we have been trying to keep all properties files in UTF-8.

Testing done

$ file core/src/main/resources/jenkins/monitor/JavaVersionRecommendationAdminMonitor/description_pt_BR.properties 
core/src/main/resources/jenkins/monitor/JavaVersionRecommendationAdminMonitor/description_pt_BR.properties: Unicode text, UTF-8 text

Proposed changelog entries

N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Give feedback

The Jira issue, if it exists, is well-described.
The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
There is automated testing or an explanation as to why this change has no tests.
New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
For dependency updates, there are links to external changelogs and, if possible, full differentials.
For new APIs and extension points, there is a link to at least one consumer.
Options

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Give feedback

There are at least two (2) approvals for the pull request and no outstanding requests for change.
Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
Proper changelog labels are set so that the changelog can be generated automatically.
If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
Options

MarkEWaite

Thanks for fixing my mistake! I was relying on emacs to preserve all the right things with character sets, but that was obviously not enough.

* master: Bump org.jenkins-ci:jenkins from 1.105 to 1.106 (jenkinsci#8550) Bump asm.version from 9.5 to 9.6 (jenkinsci#8545) Fix encoding of Brazilian Portuguese localization (jenkinsci#8549) Warn users of old Java version 18 months before end of life (jenkinsci#8543) Bump org.jenkins-ci.plugins:credentials from 1271.v54b_1c2c6388a_ to 1290.v2e5b_13eb_b_127 (jenkinsci#8548) Bump com.puppycrawl.tools:checkstyle from 10.12.3 to 10.12.4 (jenkinsci#8547) Bump io.jenkins.plugins:plugin-util-api from 3.3.0 to 3.4.0 (jenkinsci#8538)

Fix encoding of Brazilian Portuguese localization

2b53adf

basil added the skip-changelog Should not be shown in the changelog label Oct 2, 2023

basil requested a review from MarkEWaite October 2, 2023 19:01

MarkEWaite approved these changes Oct 2, 2023

View reviewed changes

basil merged commit 725f8f3 into jenkinsci:master Oct 2, 2023
2 of 3 checks passed

basil deleted the utf-8 branch October 2, 2023 19:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix encoding of Brazilian Portuguese localization #8549

Fix encoding of Brazilian Portuguese localization #8549

basil commented Oct 2, 2023 •

edited

Loading

Submitter checklist

Maintainer checklist

MarkEWaite left a comment

Fix encoding of Brazilian Portuguese localization #8549

Fix encoding of Brazilian Portuguese localization #8549

Conversation

basil commented Oct 2, 2023 • edited Loading

Testing done

Proposed changelog entries

Proposed upgrade guidelines

Submitter checklist

Desired reviewers

Maintainer checklist

MarkEWaite left a comment

Choose a reason for hiding this comment

basil commented Oct 2, 2023 •

edited

Loading